-
-
Notifications
You must be signed in to change notification settings - Fork 268
feat(ramps): add option to make requests without updating controller state #7708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
georgeweiler
wants to merge
15
commits into
main
Choose a base branch
from
TRAM-3231-no-state-update-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+160
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geolocation and countries, add countries to state, and create hydrateStore() for providers/tokens
…/core into TRAM-3231-no-state-update-options
…/core into TRAM-3231-no-state-update-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a
doNotUpdateStateoption toExecuteRequestOptionsthat enables external consumers to use RampsController methods without modifying the controller's state.doNotUpdateState?: booleantoExecuteRequestOptionsinRequestCache.tsgetCountries(),getTokens(),getProviders(), andgetPaymentMethods()to conditionally skip state updates whendoNotUpdateState: truesetUserRegion()and all trigger methodsUse Case
External teams consuming the RampsController may need to call API methods (e.g.,
getTokens,getProviders) to fetch data for display or comparison purposes without polluting the controller's persisted state. For example:References
https://consensyssoftware.atlassian.net/browse/TRAM-3231
Checklist
Note
Enables external consumers to fetch ramps data without altering controller state.
doNotUpdateStatetoExecuteRequestOptions; wire throughgetCountries(),getTokens(),getProviders(),getPaymentMethods()andtriggerGetPaymentMethods()to conditionally skip state updatesCHANGELOG.mdWritten by Cursor Bugbot for commit 910d876. This will update automatically on new commits. Configure here.